Re: [PATCH v5 2/9] ALSA: virtio: add virtio sound driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 25 Feb 2021 11:38:35 +0100,
Takashi Iwai wrote:
> 
> On Mon, 22 Feb 2021 16:34:37 +0100,
> Anton Yakovlev wrote:
> > +static int virtsnd_find_vqs(struct virtio_snd *snd)
> > +{
> > +	struct virtio_device *vdev = snd->vdev;
> > +	vq_callback_t *callbacks[VIRTIO_SND_VQ_MAX] = {
> > +		[VIRTIO_SND_VQ_EVENT] = virtsnd_event_notify_cb
> > +	};
> > +	const char *names[VIRTIO_SND_VQ_MAX] = {
> 
> Shouldn't be static?

Also callbacks[] should be static (and maybe const), I suppose.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux