On Mon, 22 Feb 2021 at 17:08, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Fri, 19 Feb 2021 17:09:12 -0600, Pierre-Louis Bossart wrote: > > No functional changes except for patch 2 and 3 where missing error > > checks were added for consistency. > > > > Pierre-Louis Bossart (6): > > ASoC: samsung: i2s: remove unassigned variable > > ASoC: samsung: s3c24xx_simtec: add missing error check > > ASoC: samsung: smdk_wm8994: add missing return > > ASoC: samsung: snow: remove useless test > > ASoC: samsung: tm2_wm5110: check of_parse return value > > ASoC: samsung: tm2_wm5510: remove shadowing variable > > > > [...] > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [5/6] ASoC: samsung: tm2_wm5110: check of_parse return value > commit: 75fa6833aef349fce1b315eaa96c9611a227014b Hi Mark, Hmmm, I had comments about this one so it should not have been applied. The check if (ret || !args.np) is still not good (or confusing) because args is an uninitialized stack value. Best regards, Krzysztof