On Fri, Feb 19, 2021 at 05:09:18PM -0600, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/samsung/tm2_wm5110.c:552:26: style: Local variable 'args' > shadows outer variable [shadowVariable] > struct of_phandle_args args; > ^ > sound/soc/samsung/tm2_wm5110.c:504:25: note: Shadowed declaration > struct of_phandle_args args; > ^ > sound/soc/samsung/tm2_wm5110.c:552:26: note: Shadow variable > struct of_phandle_args args; > ^ > > it's not clear why there was a need for a local variable at a lower > scope, remove it and share the same variable between scopes. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > --- > sound/soc/samsung/tm2_wm5110.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c > index da6204248f82..b9c17fdd168d 100644 > --- a/sound/soc/samsung/tm2_wm5110.c > +++ b/sound/soc/samsung/tm2_wm5110.c > @@ -549,7 +549,6 @@ static int tm2_probe(struct platform_device *pdev) > } > > for (i = 0; i < num_codecs; i++) { > - struct of_phandle_args args; I would prefer to have them more local, so: 1. Remove args in tm2_probe() scope. 2. Add args around line 588 in "if (num_codecs > 1) {" block. Best regards, Krzysztof