On Fri, Feb 19, 2021 at 05:09:14PM -0600, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/samsung/s3c24xx_simtec.c:191:7: style: Variable 'ret' is > assigned a value that is never used. [unreadVariable] > ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER, > ^ > > Looking at the code, it's not clear why the return value is checked in > the two other cases but not here, so mirror the behavior and add a > check. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > --- > sound/soc/samsung/s3c24xx_simtec.c | 5 +++++ > 1 file changed, 5 insertions(+) > Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Best regards, Krzysztof
