Hello Realtek +Arava, Jairaj <jairaj.arava@xxxxxxxxx> On Wed, Feb 17, 2021 at 1:49 PM Curtis Malainey <cujomalainey@xxxxxxxxxxxx> wrote: > There is a 250ms delay on the jack detect interrupt currently, this > delay is observable to users who are using inline controls. It can also > mask multiple presses which is a negative experience. > > Cc: Bard liao <yung-chuan.liao@xxxxxxxxxxxxxxx> > Cc: Shuming Fan <shumingf@xxxxxxxxxxx> > > Signed-off-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx> > --- > sound/soc/codecs/rt5682-i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/rt5682-i2c.c b/sound/soc/codecs/rt5682-i2c.c > index 93c1603b42f1..b15c3e7d1f59 100644 > --- a/sound/soc/codecs/rt5682-i2c.c > +++ b/sound/soc/codecs/rt5682-i2c.c > @@ -78,7 +78,7 @@ static irqreturn_t rt5682_irq(int irq, void *data) > struct rt5682_priv *rt5682 = data; > > mod_delayed_work(system_power_efficient_wq, > - &rt5682->jack_detect_work, msecs_to_jiffies(250)); > + &rt5682->jack_detect_work, 0); > > This change is posted to start a discussion as to the purpose of this delay, we are seeing noticeable UI delay and button masking. Is there an electro/mechanical purpose to it? If not I think I should post a V2 to remove the workqueue since this is a threaded irq. Please advise, thanks. > return IRQ_HANDLED; > } > -- > 2.30.0.478.g8a0d178c01-goog > >
