Dne 11. 02. 21 v 13:19 kernel test robot napsal(a): > Hi Jaroslav, > > I love your patch! Perhaps something to improve: > All warnings (new ones prefixed by >>): > > sound/core/control_led.c:49:19: warning: no previous prototype for 'snd_ctl_led_controls_by_access' [-Wmissing-prototypes] > 49 | struct list_head *snd_ctl_led_controls_by_access(unsigned int access) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> sound/core/control_led.c:244:6: warning: no previous prototype for 'snd_ctl_led_hello' [-Wmissing-prototypes] > 244 | void snd_ctl_led_hello(void) > | ^~~~~~~~~~~~~~~~~ I'll address both issues in v2 of the patchset (snd_ctl_led_controls_by_access function should be static and the snd_ctl_led_hello() is obsolete and it should be removed - a piece from an internal version of my code) Jaroslav -- Jaroslav Kysela <perex@xxxxxxxx> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
