Hi Jaroslav, On 2/9/21 8:56 PM, Jaroslav Kysela wrote: > Dne 09. 02. 21 v 20:08 Hans de Goede napsal(a): >> Add new UCM profile for BYT boards with a WM5102 codec. This has been >> tested with both the SST and the SOF driver on a >> Lenovo Yoga Tablet 2 1051L. > > Hans, > > could you also add the configuration for the hardware volume mixer controls? I definitely plan to look into those, but that is going to be a codec by codec thing. I want to start with the codecs which are used in devices with mute LEDs, to see if I can get the LEDs to work in combination with testing the kernel generic alsa led-trigger kernel-patch you send. So I would prefer for you to merge this as is for now. Together with the wm5102 kernel bits which just landed in -next for 5.12, this will result in working audio at the same level as all the other Intel ASoC using devices. There are only so much hours in a day... I do want to add HW volume control support to all the codecs used on Intel BYT/CHT boards but this will be something which I need to do on a case by case bases and in my spare time, so this will take a while. My priority ordering for upcoming UCM work roughly is: 1. Finish testing all codecs with SOF and fix any SOF only UCM (or kernel) issues 2. Add hw volume control for codecs used on devices with mute LEDs 3. Add hw volume control for the most popular codecs (all the rt56?? codecs, which also overlaps with 2.) 4. Deal with the remaining codecs The wm5102 firmly falls under 4. it is only used in 1 Lenovo design and I only ended up working on it at all because I happen to have such a Lenovo tablet and Pierre-Louis pointed out to me that there already was a machine-driver available in some Android kernels. Regards, Hans
