On Mon, Feb 08, 2021 at 05:04:32PM +0800, shumingf@xxxxxxxxxxx wrote:
> + /* initial settings - blind write */
> + regmap_write(rt1316->regmap, 0xc710, 0x17);
> + regmap_write(rt1316->regmap, 0xc711, 0x80);
> + regmap_write(rt1316->regmap, 0xc712, 0x26);
> + regmap_write(rt1316->regmap, 0xc713, 0x06);
> + regmap_write(rt1316->regmap, 0xc714, 0x80);
These look like a regmap patch?
> +static const char * const rt1316_xu24_bypass_ctl[] = {
> + "Not Bypass",
> + "Bypass",
> +};
Why is this an enum and not a standard switch?
> +static const char * const rt1316_lr_iv_sel[] = {
> + "0",
> + "1",
> + "2",
> + "3",
> + "4",
> + "5",
> + "6",
> + "7",
> +};
This looks like it could just be a regular control and not an enum -
this is just a normal sequence of numbers that could be mapped directlym
onto a normal control.
> +static int rt1316_sdw_set_tdm_slot(struct snd_soc_dai *dai,
> + unsigned int tx_mask,
> + unsigned int rx_mask,
> + int slots, int slot_width)
> +{
> + struct snd_soc_component *component = dai->component;
> + struct rt1316_sdw_priv *rt1316 =
> + snd_soc_component_get_drvdata(component);
> +
> + if (tx_mask)
> + return -EINVAL;
> +
> + if (slots > 2)
> + return -EINVAL;
> +
> + rt1316->rx_mask = rx_mask;
> + rt1316->slots = slots;
> + /* slot_width is not used since it's irrelevant for SoundWire */
I wouldn't expect to see any TDM stuff at all for SoundWire? I do see
some crept through though :/
Attachment:
signature.asc
Description: PGP signature
