Re: [PATCH 1/2] ALSA: hda: intel-dsp-config: Add FLAG_BYT_FIRST / _SECOND defines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 08 Feb 2021 10:37:59 +0100,
Hans de Goede wrote:
> 
> Instead of hardcording the SST driver having the highest prio, add
> FLAG_BYT_FIRST and FLAG_BYT_SECOND defines, which get set like this
> when both drivers are enabled:
> 
> 	#define FLAG_BYT_FIRST               FLAG_SST
> 	#define FLAG_BYT_SECOND              FLAG_SOF
> 
> And when only 1 driver is enabled then FLAG_BYT_FIRST gets set to
> the flag for that driver.
> 
> This is a preparation patch for making which driver is preferred
> configurable through Kconfig.
> 
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

I find the idea is fine, but the ifdef conditions become too complex
after this change.  It took minutes to check whether the ifdef changes
are really correct for me :)

So, it'd be appreciated if this can be re-designed and simplified...


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux