Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2021-02-01 10:03 PM, Cezary Rojewski wrote:
On 2021-02-01 9:01 AM, Yang Li wrote:
Eliminate the following coccicheck warning:
./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
---
  sound/soc/intel/catpt/pcm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
index e5d54bb..88a0879 100644
--- a/sound/soc/intel/catpt/pcm.c
+++ b/sound/soc/intel/catpt/pcm.c
@@ -352,7 +352,7 @@ static int catpt_dai_apply_usettings(struct snd_soc_dai *dai,
          break;
      default:
          return 0;
-    };
+    }
      list_for_each_entry(pos, &component->card->snd_card->controls, list) {
          if (pos->private_data == component &&


Hello Yang,

Your patch is much appreciated.

I noticed that more mistakes such as this have been made in the code. Could you please also update switch-statements in other parts of catpt (from what I've found, pcm.c has 2 occurrences while loader.c has 1)?


I see now. Patch [1] provided the fixes already but optimization of mine [2] done later, overridden part of it. In that case, there's nothing else to be done.

Acked-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>

Regards,
Czarek


[1]: https://lore.kernel.org/r/20201101171943.2305030-1-trix@xxxxxxxxxx
[2]: https://lore.kernel.org/r/20201116133332.8530-4-cezary.rojewski@xxxxxxxxx



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux