On 02/02/2021 15:25, Dmitry Osipenko wrote: > 02.02.2021 16:22, Jon Hunter пишет: >> So this is very similar to tegra_rt5677, is it not possible to support >> both codecs with the same machine driver? > > These codecs require individual configurations and those > "../codecs/rt5631.h" and "../codecs/rt5677.h" aren't compatible at a > quick glance. Right but not all of that is needed. What is actually needed from the header files? > The tegra_rt5677 also uses outdated GPIO API and etc. Hence the new > driver should be a better base anyways. Sounds like a good time to update it :-) > Overall it shouldn't worth time and effort trying to squeeze these > drivers into a single one, IMO. Not sure I agree when these drivers appear to be 90% the same. Jon -- nvpublic
