On Wed, Jan 27, 2021 at 11:22 PM Cezary Rojewski <cezary.rojewski@xxxxxxxxx> wrote: > > On 2021-01-27 9:03 AM, Kai-Heng Feng wrote: > > On Mon, Jan 25, 2021 at 7:55 PM Cezary Rojewski > > <cezary.rojewski@xxxxxxxxx> wrote: > >> > >> Skylake is dependent on SND_SOC_INTEL_SKYLAKE (aka "all SST platforms") > >> whereas selecting specific configuration such as KBL-only will not > >> cause driver code to compile. Switch to SND_SOC_INTEL_SKYLAKE_COMMON > >> dependency so selecting any configuration causes the driver to be built. > >> > >> Reported-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx> > >> Suggested-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx> > >> Fixes: 35bc99aaa1a3 ("ASoC: Intel: Skylake: Add more platform granularity") > >> Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx> > > > > Still not working: > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1902457/comments/66 > > > > Hello, > > Thanks for your reply Kai-Heng. > I believe you're relating to completely different issue than the one > this very patch is targeting. Understood. > > From the logs you've provided one can see that snd_soc_skl did attempt > to probe() so the code compiled just fine. Again, compilation issue is > the one I've addressed here. While we're here, I'd appreciate kconfig > being provided along dmesg file. Logs alone do not show the entire > picture, unfortunately. Config file here: https://pastebin.ubuntu.com/p/kGBv6XgHms/ > > In regard to missing sound, (looks like we're talking about HDA dsp + > DMIC configuration) kconfig mentioned above will be required. Pretty > sure HDAudio support for skylake-driver is not enabled on your machine > and thus driver exists probe() early without registering any sound card. Do you mean CONFIG_SND_SOC_INTEL_SKYLAKE_HDAUDIO_CODEC needs to be enabled? Kai-Heng > > Regards, > Czarek