On Sat, 23 Jan 2021 18:29:45 +0100, Sebastian Reichel wrote: > The correct mask is 0x1f8 (Bit 3-8), but due to missing BIT() 0xf (Bit > 0-3) was set instead. This means setting of CPCAP_BIT_MIC1_RX_TIMESLOT0 > (Bit 3) still worked (part of both masks). On the other hand the code > does not properly clear the other MIC timeslot bits. I think this > is not a problem, since they are probably initialized to 0 and not > touched by the driver anywhere else. But the mask also contains some > wrong bits, that will be cleared. Bit 0 (CPCAP_BIT_SMB_CDC) should be > safe, since the driver enforces it to be 0 anyways. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: cpcap: fix microphone timeslot mask commit: de5bfae2fd962a9da99f56382305ec7966a604b9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
