On 1/26/21 7:46 PM, Kai Vehmanen wrote:
Hi, I gave this v8 series another review and did some actual testing with the patchset and looking good. Caching the hw status is a nice addition and the new underscore-replaced names look better than the early versions. Only some very minor comments to the code: On Tue, 26 Jan 2021, Hui Wang wrote:static void snd_jack_kctl_add(struct snd_jack *jack, struct snd_jack_kctl *jack_kctl) { + jack_kctl->jack = jack; list_add_tail(&jack_kctl->list, &jack->kctl_list); + if (!strstr(jack_kctl->kctl->id.name, "Phantom")) + snd_jack_debugfs_add_inject_node(jack, jack_kctl); }This comparison is now done even if injection is disabled at build time. Maybe better to have this check on injection side? Or even not filter Phantom jacks at all and leave this for user-space to tackle?
So far there is no requirement to create injection interface for Phantom jacks, if users need Phantom jacks interface in future, we could add them then. Here I will move the comparison on injection side.
Thanks, Hui.
Br, Kai
