On Sat, Jan 23, 2021 at 2:17 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Cleanup the use of dev_foo functions used for logging:
>
> 1. Many of these are unnecessarily split over multiple lines
> 2. Use dev_err_probe() in cases where we might get a -EPROBE_DEFER
> return value
...
> if (IS_ERR(info->micd_pol_gpio)) {
> ret = PTR_ERR(info->micd_pol_gpio);
> - dev_err(arizona->dev,
> - "Failed to get microphone polarity GPIO: %d\n",
> - ret);
> + dev_err_probe(arizona->dev, ret, "getting microphone polarity GPIO\n");
> return ret;
> }
I still think that using dev_err_probe() naturally, i.e. as a part of
the return statement is better.
--
With Best Regards,
Andy Shevchenko
