At Tue, 29 Jan 2008 09:31:04 +0100, Hermann Lauer wrote: > > On Thu, Jan 24, 2008 at 04:40:18PM +0100, Takashi Iwai wrote: > > > > > The patch is, however, unable to apply as is because of coding style > > > > problems. Try $LINUXKERNEL/scripts/checkpatch.pl, fix what are > > > > suggested there, and repost the patch together with your sign-off. > > > > > > Will do that when I digged trough the details (have to learn about signing). > > > > See $LINUX/Documentation/SubmittingPatches. > > Appended is a cleaned up version of the patch. checkpatch.pl is now > only mucking about the '#if 0' commented out old branch. Should this > be removed or the if-else parts exchanged, which probably will calm down > checkpatch.pl ? That's fine. checkpatch.pl is no strict rule to apply. > Have to check compilation, then I will send a signed version. Thanks. One missing thing is the initialization of last_capture_dmaaddr. This should be set to zero in prepare callback. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
