On Thu, Jan 21, 2021 at 09:42:04PM +0100, Christophe JAILLET wrote: > Hi Dan, > > Le 21/01/2021 à 07:10, Dan Carpenter a écrit : > > If "ff->dev_lock_changed" has not changed > > According to the "while (!ff->dev_lock_changed) { ... }" just above and the > lock in place, can this ever happen? > > In other word, I wonder if the "if (ff->dev_lock_changed)" test makes sense > and if it could be removed. > > > (same for your other patch against sound/firewire/oxfw/oxfw-hwdep.c) > Yeah. That's a good point. I'll resend. regards, dan carpenter