Thanks Ricardo - I have checked it on Eve/Google Pixelbook Tested-by: Lukasz Majczak <lma@xxxxxxxxxxxx> czw., 21 sty 2021 o 18:33 Rojewski, Cezary <cezary.rojewski@xxxxxxxxx> napisał(a): > > On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > > If dobj->control is not initialized we end up in an OOPs during > > skl_tplg_complete: > > > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > > 0000000000000078 > > [ 26.561151] #PF: supervisor read access in kernel mode > > [ 26.566897] #PF: error_code(0x0000) - not-present page > > [ 26.572642] PGD 0 P4D 0 > > [ 26.575479] Oops: 0000 [#1] PREEMPT SMP PTI > > [ 26.580158] CPU: 2 PID: 2082 Comm: udevd Tainted: G C > > 5.4.81 #4 > > [ 26.588232] Hardware name: HP Soraka/Soraka, BIOS > > Google_Soraka.10431.106.0 12/03/2019 > > [ 26.597082] RIP: 0010:skl_tplg_complete+0x70/0x144 [snd_soc_skl] > > > > Fixes: 2d744ecf2b98 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHL") > > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > > Thanks for the fix, Ricardo. > > Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx> >