Re: [PATCH] ASoC: qcom: lpass: Fix i2s ctl register bit map

[Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>]

On 19/01/2021 17:37, Srinivas Kandagatla wrote:
> Thanks for the Patch Jun,
>
> On 19/01/2021 07:17, Jun Nie wrote:
> > Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> >
> > Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx>
>
>
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>


I sent reply too quickly, just realized that this was a regression from

 b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and 
dmactl registers")

So can you add Fixes tag and resend your patch!

--srini

> --srini
>
> > ---
> >   sound/soc/qcom/lpass-apq8016.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/qcom/lpass-apq8016.c 
> > b/sound/soc/qcom/lpass-apq8016.c
> > index 0aedb3a0a798..7c0e774ad062 100644
> > --- a/sound/soc/qcom/lpass-apq8016.c
> > +++ b/sound/soc/qcom/lpass-apq8016.c
> > @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
> >       .micmode        = REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
> >       .micmono        = REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
> >       .wssrc            = REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> > -    .bitwidth        = REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> > +    .bitwidth        = REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
> >       .rdma_dyncclk        = REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
> >       .rdma_bursten        = REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),