Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on lee-mfd/for-mfd-next] [also build test ERROR on asoc/for-next v5.11-rc3 next-20210115] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/MFD-ASoC-Add-support-for-Intel-Bay-Trail-boards-with-WM5102-codec/20210117-235249 base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next config: sh-randconfig-s031-20210118 (attached as .config) compiler: sh4-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.3-208-g46a52ca4-dirty # https://github.com/0day-ci/linux/commit/ff3c43e0ca3dd07a3b671ee3be84b9c607dff305 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hans-de-Goede/MFD-ASoC-Add-support-for-Intel-Bay-Trail-boards-with-WM5102-codec/20210117-235249 git checkout ff3c43e0ca3dd07a3b671ee3be84b9c607dff305 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sh If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs] cc1: warning: arch/sh/include/mach-rsk: No such file or directory [-Wmissing-include-dirs] drivers/mfd/arizona-spi.c: In function 'arizona_spi_probe': >> drivers/mfd/arizona-spi.c:194:7: error: void value not ignored as it ought to be 194 | ret = arizona_spi_acpi_probe(arizona); | ^ vim +194 drivers/mfd/arizona-spi.c 135 136 static int arizona_spi_probe(struct spi_device *spi) 137 { 138 const struct spi_device_id *id = spi_get_device_id(spi); 139 const void *match_data; 140 struct arizona *arizona; 141 const struct regmap_config *regmap_config = NULL; 142 unsigned long type = 0; 143 int ret; 144 145 match_data = device_get_match_data(&spi->dev); 146 if (match_data) 147 type = (unsigned long)match_data; 148 else if (id) 149 type = id->driver_data; 150 151 switch (type) { 152 case WM5102: 153 if (IS_ENABLED(CONFIG_MFD_WM5102)) 154 regmap_config = &wm5102_spi_regmap; 155 break; 156 case WM5110: 157 case WM8280: 158 if (IS_ENABLED(CONFIG_MFD_WM5110)) 159 regmap_config = &wm5110_spi_regmap; 160 break; 161 case WM1831: 162 case CS47L24: 163 if (IS_ENABLED(CONFIG_MFD_CS47L24)) 164 regmap_config = &cs47l24_spi_regmap; 165 break; 166 default: 167 dev_err(&spi->dev, "Unknown device type %ld\n", type); 168 return -EINVAL; 169 } 170 171 if (!regmap_config) { 172 dev_err(&spi->dev, 173 "No kernel support for device type %ld\n", type); 174 return -EINVAL; 175 } 176 177 arizona = devm_kzalloc(&spi->dev, sizeof(*arizona), GFP_KERNEL); 178 if (arizona == NULL) 179 return -ENOMEM; 180 181 arizona->regmap = devm_regmap_init_spi(spi, regmap_config); 182 if (IS_ERR(arizona->regmap)) { 183 ret = PTR_ERR(arizona->regmap); 184 dev_err(&spi->dev, "Failed to allocate register map: %d\n", 185 ret); 186 return ret; 187 } 188 189 arizona->type = type; 190 arizona->dev = &spi->dev; 191 arizona->irq = spi->irq; 192 193 if (has_acpi_companion(&spi->dev)) { > 194 ret = arizona_spi_acpi_probe(arizona); 195 if (ret) 196 return ret; 197 } 198 199 return arizona_dev_init(arizona); 200 } 201 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
