On Tue, Jan 12, 2021 at 03:58:32PM +0300, Dmitry Osipenko wrote: > Some of resets are erroneously missed in the configlink_mods[], like APBIF > for example. Use of_reset_control_array_get_exclusive() which requests all > the resets. The problem was hidden by the clk driver which implicitly > de-asserts the missing resets. > > Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> > Tested-by: Nicolas Chauvet <kwizart@xxxxxxxxx> > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > sound/soc/tegra/tegra30_ahub.c | 66 +++++----------------------------- > sound/soc/tegra/tegra30_ahub.h | 1 - > 2 files changed, 9 insertions(+), 58 deletions(-) Doing it this way is slightly suboptimal because now we don't actually have a way of checking that the DT has all the necessary resets listed. Can we not just make the list complete instead to keep the checks in place? That should be a much smaller patch, too. Thierry
Attachment:
signature.asc
Description: PGP signature
