Re: [PATCH 0/4] ASoC: qcom: Minor code cleanups for lpass-cpu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Stephen for the cleanup patches.

All of them look good to me!

On 15/01/2021 03:43, Stephen Boyd wrote:
Here's some minor code cleanups for the lpass-cpu driver. I noticed that
it casts away const from the driver data from DT. That's not great but
fixing it is a little more involved. I'll get to it later. There's also
some questionable clk_get() usage that should probably be
clk_get_optional(). For now this should help a little.

Cc: V Sujith Kumar Reddy <vsujithk@xxxxxxxxxxxxxx>
Cc: Srinivasa Rao <srivasam@xxxxxxxxxxxxxx>
Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
Cc: Cheng-Yi Chiang <cychiang@xxxxxxxxxxxx>

Stephen Boyd (4):
   ASoC: qcom: Remove useless debug print
   ASoC: qcom: Add some names to regmap configs
   ASoC: qcom: Stop casting away __iomem for error pointers
   ASoC: qcom: Remove duplicate error messages on ioremap

  sound/soc/qcom/lpass-cpu.c | 17 ++++++-----------
  1 file changed, 6 insertions(+), 11 deletions(-)



Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux