Hi, On 12/1/21 15:10, Mark Brown wrote: > On Mon, Jan 11, 2021 at 05:52:31PM -0800, Guenter Roeck wrote: >> On Mon, Jan 11, 2021 at 4:42 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > >>> TBH that seems like a big enough change to split out from this and done >>> as a separate series, I'd be perfectly happy to apply your original >>> change. I guess part of doing that sync up should ideally be to >>> refactor things so that it can be done mechanically in future. > >> Being able to do it mechanically was the idea for introducing the script. >> Unfortunately it doesn't help to have such a script if people don't use it. > > Looking at the issues Yu-Hsuan mentions and briefly at the code I guess > there's some updates needed with the script for namespacing around at > least pd_ to avoid the need for hand massaging things, that'll put > people off using the script. > I even didn't know about that script :-(, or forget about it, assuming the files are async again, I think I'm fine on only introduce that line of code instead of a full sync (and lets think how we can do better work on this and solve in the chrome-platform tree). I have some comments on patch 2, though. Cheers, Enric
