> -----Original Message-----
> From: Xu Wang <vulab@xxxxxxxxxxx>
> Sent: Friday, January 8, 2021 9:45 AM
> To: lars@xxxxxxxxxx; Sa, Nuno <Nuno.Sa@xxxxxxxxxx>;
> lgirdwood@xxxxxxxxx; broonie@xxxxxxxxxx; perex@xxxxxxxx;
> tiwai@xxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH] ASoC: adau17x1: Remove redundant null check
> before clk_disable_unprepare
>
>
> Because clk_disable_unprepare() already checked NULL clock
> parameter,
> so the additional check is unnecessary, just remove it.
>
> Signed-off-by: Xu Wang <vulab@xxxxxxxxxxx>
> ---
> sound/soc/codecs/adau17x1.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/adau17x1.c
> b/sound/soc/codecs/adau17x1.c
> index 30e072c80ac1..546ee8178038 100644
> --- a/sound/soc/codecs/adau17x1.c
> +++ b/sound/soc/codecs/adau17x1.c
> @@ -1095,8 +1095,7 @@ void adau17x1_remove(struct device *dev)
> {
> struct adau *adau = dev_get_drvdata(dev);
>
> - if (adau->mclk)
> - clk_disable_unprepare(adau->mclk);
> + clk_disable_unprepare(adau->mclk);
> }
> EXPORT_SYMBOL_GPL(adau17x1_remove);
This is fine by me but since you are touching this, you could also just replace the
remove() hook in all the users with devm_add_action_or_reset().
- Nuno Sá
