On Mon, Dec 14, 2020 at 09:14:13AM +0000, Rojewski, Cezary wrote: > On 2020-12-08 11:26 AM, Andy Shevchenko wrote: > > Since we got list_entry_is_head() helper in the generic header, > > we may switch catpt to use it. It removes the need in additional variable. > > Thanks for the patch, Andy. One nitpick below. ... > > struct catpt_dev *cdev = dev_get_drvdata(dai->dev); > > struct snd_soc_component *component = dai->component; > > - struct snd_kcontrol *pos, *kctl = NULL; > > const char *name; > > int ret; > > u32 id = stream->info.stream_hw_id; > > + struct snd_kcontrol *pos; > > Shouldn't structs be declared before any primitive-types? Good question. I consider the length of the line is more important (to keep reversed xmas tree order). If you think we should leave as is tell me, I'll send v2. -- With Best Regards, Andy Shevchenko
