Re: [PATCH] ALSA: hda/hdmi: packet buffer index must be set before reading value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, 11 Dec 2020, Takashi Iwai wrote:

> On Fri, 11 Dec 2020 14:16:13 +0100, Kai Vehmanen wrote:
> > 
> > The check for infoframe transmit status in hdmi_infoframe_uptodate()
> > makes the assumption that packet buffer index is set to zero.
> 
> Currently there is no other place to change DIP index, i.e. it's
> always zero, and the bug wouldn't hit, but it's better to be addressed
> beforehand, indeed.

indeed, agreed on that. Most likely scenario where this could actually 
cause harm if someone later adds new functionality to this driver that 
uses other DIP indices for something. That's pretty unlikely as well, but 
yeah, better align with the spec.

Br, Kai



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux