Hey, thanks Takashi for the quick review! On Thu, 10 Dec 2020, Takashi Iwai wrote: > On Thu, 10 Dec 2020 16:39:54 +0100, Kai Vehmanen wrote: > > +static void silent_stream_disable(struct hda_codec *codec, > > + struct hdmi_spec_per_pin *per_pin) [..] > > + > > + per_pin->cvt_nid = 0; > > + per_pin->silent_stream = false; > > +} > > Better to protect with per_pin->lock? oops, yes, definitely yes. I'll spin a v2 of this. Br, Kai