> -----Original Message----- > From: Mark Brown <broonie@xxxxxxxxxx> > Sent: Tuesday, December 1, 2020 9:58 PM > To: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>; tiwai@xxxxxxx > Cc: pierre-louis.bossart@xxxxxxxxxxxxxxx; vkoul@xxxxxxxxxx; Liao, Bard > <bard.liao@xxxxxxxxx>; kai.vehmanen@xxxxxxxxxxxxxxx; > ryans.lee@xxxxxxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx > Subject: Re: [RFC] ASoC: max98373: don't access volatile registers in bias level > off > > On Mon, 9 Nov 2020 21:55:43 +0800, Bard Liao wrote: > > We will set regcache_cache_only true in suspend. As a result, > > regmap_read will return error when we try to read volatile registers in > suspend. > > Besides, it doesn't make sense to read feedback data when codec is not > > active. To avoid the regmap_read error, this patch try to return a > > fake value when kcontrol _get is called in suspend. > > However, the question is what is the "correct" behavior when we try to > > read a volatile register when cache only is set. > > 1. return an error code to signal codec is not available as what we > > have now. > > 2. return a fake value like what this patch do. > > 3. wake-up the codec and always return a valid value. > > Applied to > > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next > > Thanks! > > [1/1] ASoC: max98373: don't access volatile registers in bias level off > (no commit info) > Hi Mark, Sorry but I don't find the patch on your tree. Is it applied? Does "no commit info" mean the commit doesn't apply? Thanks, Bard
