On Tue, 08 Dec 2020 22:25:43 +0100,
Connor McAdams wrote:
>
> +static void chipio_8051_write_exram(struct hda_codec *codec,
> + unsigned int addr, unsigned int data, bool use_mutex)
> +{
> + struct ca0132_spec *spec = codec->spec;
> + unsigned int tmp;
> +
> + if (use_mutex)
> + mutex_lock(&spec->chipio_mutex);
This can be better to split to two functions: a core helper function
without mutex and a helper function to take the mutex lock and call
the former function. Applying the lock conditionally is often
error-prone.
thanks,
Takashi
