Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Vinod Koul <vkoul@xxxxxxxxxx>, Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write
From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Date: Sat, 5 Dec 2020 08:43:49 -0600
Cc: alsa-devel@xxxxxxxxxxxxxxxx, tiwai@xxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, ranjani.sridharan@xxxxxxxxxxxxxxx, hui.wang@xxxxxxxxxxxxx, broonie@xxxxxxxxxx, srinivas.kandagatla@xxxxxxxxxx, jank@xxxxxxxxxxx, sanyog.r.kale@xxxxxxxxx, rander.wang@xxxxxxxxxxxxxxx, bard.liao@xxxxxxxxx
In-reply-to: <20201205074554.GR8403@vkoul-mobl>
References: <20201202204645.23891-1-yung-chuan.liao@linux.intel.com> <20201202204645.23891-5-yung-chuan.liao@linux.intel.com> <20201205074554.GR8403@vkoul-mobl>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

-static int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
+int sdw_write_no_pm(struct sdw_slave *slave, u32 addr, u8 value)
  {
  	return sdw_nwrite_no_pm(slave, addr, 1, &value);
  }
+EXPORT_SYMBOL(sdw_write_no_pm);


Why not export this is patch 1..?

yes, good point. I guess Bard and I were debugging in parallel andmissed this. thanks for pointing it out.

References:
- [PATCH 0/7] soundwire/regmap: use _no_pm routines
  - From: Bard Liao
- [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write
  - From: Bard Liao
- Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write
  - From: Vinod Koul

Prev by Date: thinkpad t14s amd: unable to control built-in mic and headphones mic independently
Next by Date: Re: [PATCH 5/7] regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
Previous by thread: Re: [PATCH 4/7] soundwire/regmap: use _no_pm functions in regmap_read/write
Next by thread: [PATCH 5/7] regmap: sdw: use no_pm routines for SoundWire 1.2 MBQ
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]