> > +struct { > > + unsigned int tx; > > + unsigned int rx; > > +} rt1011_tdm_mask[] = { > > + {.tx = 0x4, .rx = 0x1}, > > + {.tx = 0x8, .rx = 0x2}, > > +}; > > as noted in the GitHub review this should be static and possibly const. Will fix in v2. Also add const to structures in soc-acpi-intel-tgl-match.c and include file in sof_realtek_common.c Regards, Brent