Hi Takashi, Here's the sign-off: Signed-off-by: Marc Boucher <marc@xxxxxxxxxxxx> Do you have any specific comments about the code itself? Kind regards, Marc -- Marc Boucher Linuxant inc. http://www.linuxant.com On 21-Jan-08, at 12:26 PM, Takashi Iwai wrote: > At Mon, 21 Jan 2008 08:14:31 -0800, > Tobin Davis wrote: >> >> Forwarded from the good people at Linuxant. >> >> Tobin >> -------- Forwarded Message -------- >> From: Marc Boucher <marc@xxxxxxxxxxxx> >> To: Tobin Davis <tdavis@xxxxxxxxxxxx> >> Cc: Linuxant support (Jonathan) <support@xxxxxxxxxxxx> >> Subject: Re: Code relsease to alsa. >> Date: Mon, 21 Jan 2008 10:33:03 -0500 >> >> Tobin, >> >> As promised here is our current tentative patch (relative to the >> current ALSA development tree in hg) for merging with ALSA. >> >> It is also available from: >> >> http://www.linuxant.com/alsa-hg-20080120.patch >> >> Naturally the changes are released under the GPL, so feel free to >> integrate them. >> >> Comments and improvements are welcome. >> >> Kind regards, >> >> Marc >> >> -- >> Marc Boucher >> Linuxant inc. >> http://www.linuxant.com > > First of all, thanks for the patch. > Now just taking a quick look, I'd like to ask you about the following > items: > > - Split the HSF modem part and other part. The HSF modem part is > hardly to be merged (as you know why), but the other parts could be > merged easily if needed. > > - Split the rest, misc fixes. If the fix is reasonable, it should be > applied immediately. > > These will make both of our lives much easier. > > And, one more thing: > > - Give your sign-off to be merged to the upstream > > This is mandatory for untrivial changes. This clarifies the copyright > and avoids the possible legal issues in future. > > > thanks, > > Takashi > >> >> On 19-Jan-08, at 6:40 PM, Marc Boucher wrote: >> >>> >>> Hi Tobin, >>> >>> We have isolated the modifications in patch form and are currently >>> working to merge them with the latest ALSA tree / submit them back >>> upstream. >>> >>> By the way, all changes and code under the modules/GPL/ directory >>> (including the hda subdirectory) of our modem driver are released >>> under the GPL, so you would be free to take these fixes if you'd >>> like. >>> >>> However you would be also welcome to reviewing the patches that we >>> are about to submit. I will arrange to send you a copy asap (should >>> be next week). >>> >>> Kind regards, (and many thanks for your great contributions to ALSA) >>> >>> Marc >>> >>> PS: We could also try to help you getting any missing info on the >>> CX20561 or other things from Conexant... >>> >>> -- >>> Marc Boucher >>> Linuxant inc. >>> http://www.linuxant.com >>> >>> On 19-Jan-08, at 1:07 PM, Tobin Davis wrote: >>> >>>> Hello, >>>> >>>> I'm the developer that put the current audio support for the >>>> Conexant HD Audio codecs in alsa. I worked many hours on this, >>>> with testers around the world sending me feedback. Most of the >>>> work was done prior to Conexant offering me any documentation. I >>>> have since received documentation for both CX20549 (Venice), and >>>> CX20551 (Waikiki), but am waiting for the latest info on the new >>>> CX20561, which you apparently already have. >>>> >>>> I have also seen in your mailing list that you are providing >>>> several fixes to the audio portion of my code, but only making them >>>> available to users of your code, which requires a license agreement >>>> that I believe is incompatible with the GPL. At the least, it >>>> prohibits someone like me taking any of these fixes and putting >>>> them in the mainstream alsa, where more users would benefit from >>>> them. >>>> >>>> What I'm asking, is if you could at least provide the audio >>>> modifications back upstream to alsa? It would help out far more >>>> users (modem usage is on the decline - sorry), and you would have >>>> some benefit in that your name would be in the source as well. >>>> >>>> >>>> -- >>>> Tobin Davis <tdavis@xxxxxxxxxxxx> >>> >> >> -- Tobin >> Davis >> >> >> no maintenance: >> Impossible to fix. >> >> > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
