Takashi Iwai wrote: > At Mon, 21 Jan 2008 08:58:52 -0500, > Matthew Ranostay wrote: >> Takashi Iwai wrote: >>> At Fri, 18 Jan 2008 16:44:42 -0500, >>> Matthew Ranostay wrote: >>>> Some 92HD7XXX family codecs have a mono mux, added support for selecting the input path to the mono out. >>>> >>>> Signed-off-by: Matthew Ranostay <mranostay@xxxxxxxxxxxxxxxxx> >>> Could you fix the coding-style issues reported by checkpatch.pl? >> Ok, fixed the 80-character lines it complained about, although I left the 'declaration in if statement' since >> the code block below it does the same style. > > Well, apprently you didn't run checkpatch.pl to the new patch? ;) > > ERROR: do not use assignment in if condition (+ if ((err = stac92xx_auto_create_mono_output_ctls(codec)) < 0)) > #224: FILE: pci/hda/patch_sigmatel.c:2609: > + if ((err = stac92xx_auto_create_mono_output_ctls(codec)) < 0) > I did but I didn't change it because the line below it does the same coding style. But in that case I'll change both :) > total: 1 errors, 0 warnings, 153 lines checked > > > Takashi > _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
