On Mon, Nov 23, 2020 at 04:43:30PM +0000, Mark Brown wrote: > On Mon, Nov 23, 2020 at 03:58:31PM +0100, Krzysztof Kozlowski wrote: > > > Having these of_match_ptr() for OF-only drivers is not the correct way > > but rather something which is copied from existing drivers into new > > ones. This is another reason for removing them - people will stop > > copying this code all over again. > > Well, it seems that the issue the PRP0001 people are having is that > they'd rather that there were fewer OF only drivers! More generally > it is good practice to write things as though there might be non-DT > support even if it's not there at the present time, it's easier to not > have to think if it's strictly needed and it helps anyone coming along > later who does want to use things elsewhere. I understand. I will send therefore a v2 adding __maybe_unused to the OF table. Best regards, Krzysztof
