On Mon, Nov 16, 2020 at 11:02 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Nov 17, 2020 at 07:30:00AM +0200, Leon Romanovsky wrote: > > On Fri, Nov 13, 2020 at 08:18:50AM -0800, Dave Ertman wrote: > > > Add support for the Auxiliary Bus, auxiliary_device and auxiliary_driver. > > > It enables drivers to create an auxiliary_device and bind an > > > auxiliary_driver to it. > > > > > > The bus supports probe/remove shutdown and suspend/resume callbacks. > > > Each auxiliary_device has a unique string based id; driver binds to > > > an auxiliary_device based on this id through the bus. > > > > > > Co-developed-by: Kiran Patil <kiran.patil@xxxxxxxxx> > > > Signed-off-by: Kiran Patil <kiran.patil@xxxxxxxxx> > > > Co-developed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx> > > > Signed-off-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx> > > > Co-developed-by: Fred Oh <fred.oh@xxxxxxxxxxxxxxx> > > > Signed-off-by: Fred Oh <fred.oh@xxxxxxxxxxxxxxx> > > > Co-developed-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx> > > > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > > Reviewed-by: Shiraz Saleem <shiraz.saleem@xxxxxxxxx> > > > Reviewed-by: Parav Pandit <parav@xxxxxxxxxxxx> > > > Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx> > > > Signed-off-by: Dave Ertman <david.m.ertman@xxxxxxxxx> > > > --- > > > > Greg, > > > > This horse was beaten to death, can we please progress with this patch? > > Create special topic branch or ack so I'll prepare this branch. > > > > We are in -rc4 now and we (Mellanox) can't hold our submissions anymore. > > My mlx5_core probe patches [1] were too intrusive and they are ready to > > be merged, Parav's patches got positive review as well [2] and will be > > taken next. > > > > We delayed and have in our internal queues the patches for VDPA, eswitch > > and followup for mlx5_core probe rework, but trapped due to this AUX bus > > patch. > > There are no deadlines for kernel patches here, sorry. Give me some > time to properly review this, core kernel changes should not be rushed. > > Also, if you really want to blame someone for the delay, look at the > patch submitters not the reviewers, as they are the ones that took a > very long time with this over the lifecycle of this patchset, not me. I > have provided many "instant" reviews of this patchset, and then months > went by between updates from them. Please stop this finger pointing. It was already noted that the team, out of abundance of caution / deference to the process, decided not to push the patches while I was out on family leave. It's cruel to hold that against them, and if anyone is to blame it's me for not clarifying it was ok to proceed while I was out.
