Re: [PATCH RESEND 0/3] alsa-lib/ASoC: use inclusive language for bclk/fsync/topology

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Nov 2020 17:29:37 +0100,
Pierre-Louis Bossart wrote:
> 
> This patchset is just a rebase of the code suggested in September [1],
> resent for convenience for comparison with kernel patches.
> 
> The SOF (Sound Open Firmware) tree contains a lot of references in
> topology files to 'codec_slave'/'codec_master' terms, which in turn
> come from alsa-lib and ALSA/ASoC topology support at the kernel
> level. These terms are no longer compatible with the guidelines
> adopted by the kernel community [2], standard organizations, and need
> to change in backwards-compatible ways.
> 
> The main/secondary terms typically suggested in guidelines don't mean
> anything for clocks, this patchset suggests instead the use of
> 'provider' and 'consumer' terms, with the 'codec' prefix kept to make
> it clear that the codec is the reference. The CM/CS suffixes are also
> replaced by CP/CC.
> 
> It can be argued that the change of suffix is invasive, but finding a
> replacement that keeps the M and S shortcuts has proven difficult in
> quite a few contexts.
> 
> The previous definitions are kept for backwards-compatibility so this
> change should not have any functional impact. It is suggested that new
> contributions only use the new terms but there is no requirement to
> transition immediately to the new definitions for existing code. Intel
> will however update all its past contributions related to bit
> clock/frame sync configurations immediately.
> 
> This patchset contains the alsa-lib changes only, the kernel changes
> will be shared in a different patchset. The SOF firmware changes are
> already applied, only topology-related changes will be modified after
> alsa-lib changes.
> 
> Feedback welcome
> ~Pierre
> 
> [1] https://mailman.alsa-project.org/pipermail/alsa-devel/2020-September/174387.html
> [2] https://lkml.org/lkml/2020/7/4/229
> 
> Changes since RFC:
> replaced 'follower' by 'consumer' as suggested by Jaroslav and Marc
> minor cleanups
> 
> Pierre-Louis Bossart (3):
>   topology: use inclusive language for bclk
>   topology: use inclusive language for fsync
>   topology: use inclusive language in documentation

Applied all three patches now.  Thanks.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux