alsa-project/alsa-gobject pull request #49 was opened from takaswie: The patchset is a part of work about #47. Current implementation uses library-wide error domain to report error. this is partly against rule of GError usage. Furthermore, the error delivers information just about errno and hard to know the cause of error. This patchset enhances error reporting. The library-wide error domain is obsoleted. A new error domain is added just for ALSATimer.UserInstance. The error domain delivers information about the cause of error. ``` Takashi Sakamoto (16): timer: user_instance: fix function comment timer: skip check of return value from g_malloc() timer: check whether method argument for GError is available timer: add checks for method arguments timer: instance-params: add checks for method arguments timer: user_instance: just return when character device is not opened timer: add GLib enumeration to report type of error for ALSATimer.UserInstance timer: user_instance: add GQuark to report error for ALSATimer.UserInstance timer: user_instance: report error due to ioctl failure timer: user_instance: report error due to open system call timer: user_instance: report error for timer instance not found timer: user_instance: report error for unattached timer instance timer: user_instance: report error for timer already attached timer: query: use GFileError to report error timer: query: code refactoring to unify open function timer: obsolete library-wide GQuark for error reporting src/timer/alsatimer-enum-types.h | 18 ++++ src/timer/alsatimer.map | 5 + src/timer/instance-params.c | 20 ++-- src/timer/instance-status.c | 3 +- src/timer/privates.h | 6 -- src/timer/query.c | 127 ++++++++++++------------ src/timer/user-instance.c | 165 +++++++++++++++++++++++-------- src/timer/user-instance.h | 4 + tests/alsatimer-enums | 8 ++ 9 files changed, 231 insertions(+), 125 deletions(-) ``` Request URL : https://github.com/alsa-project/alsa-gobject/pull/49 Patch URL : https://github.com/alsa-project/alsa-gobject/pull/49.patch Repository URL: https://github.com/alsa-project/alsa-gobject
