Re: [PATCH v2 00/12] ASoC: soc-component: add snd_soc_component_xxx()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2020-11-13 at 13:14 +0900, Kuninori Morimoto wrote:
> Hi Mark
> 
> These are v2 of snd_soc_component_compr_xxx() function patches.
> I think component related function should be implemented at
> soc-component.c, otherwise it is confusable to read.
> These are for it.
> 
> v1 -> v2
> 	- fixup function return timing on
> 		snd_soc_component_compr_get_params()
> 		snd_soc_component_compr_get_metadata()
> 
> 	- use mutex at compr side on
> 		snd_soc_component_compr_get_caps()
> 		snd_soc_component_compr_get_codec_caps()
> 		snd_soc_component_compr_copy()
> 
> Link: 
> https://lore.kernel.org/r/878sb78ac4.wl-kuninori.morimoto.gx@xxxxxxxxxxx
> 
> Kuninori Morimoto (12):
>   ASoC: soc-component: add snd_soc_component_compr_open()
>   ASoC: soc-component: add snd_soc_component_compr_free()
>   ASoC: soc-component: add snd_soc_component_compr_trigger()
>   ASoC: soc-component: add snd_soc_component_compr_set_params()
>   ASoC: soc-component: add snd_soc_component_compr_get_params()
>   ASoC: soc-component: add snd_soc_component_compr_get_caps()
>   ASoC: soc-component: add snd_soc_component_compr_get_codec_caps()
>   ASoC: soc-component: add snd_soc_component_compr_ack()
>   ASoC: soc-component: add snd_soc_component_compr_pointer()
>   ASoC: soc-component: add snd_soc_component_compr_copy()
>   ASoC: soc-component: add snd_soc_component_compr_set_metadata()
>   ASoC: soc-component: add snd_soc_component_compr_get_metadata()

LGTM. Thanks, Morimoto-san.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux