On 2020-11-12 11:38 PM, Pierre-Louis Bossart wrote: > For some reason this ops is missing in 2 out of the 3 broadwell > drivers. Add to make sure ASoC takes care of power management. > Changes provided with this patch are not connected to the overall idea behind your patchset. I suggest splitting pm-changes into a separate one. The very first sentence in commit message isn't providing any value, guess one-liner will suffice. > Tested-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx> > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > Reviewed-by: Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx> > Reviewed-by: Rander Wang <rander.wang@xxxxxxxxxxxxxxx> > Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@xxxxxxxxxxxxxxx> > --- > sound/soc/intel/boards/broadwell.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/intel/boards/broadwell.c b/sound/soc/intel/boards/broadwell.c > index 77c85f17aca6..69e0b13b47f4 100644 > --- a/sound/soc/intel/boards/broadwell.c > +++ b/sound/soc/intel/boards/broadwell.c > @@ -318,6 +318,7 @@ static struct platform_driver broadwell_audio = { > .remove = broadwell_audio_remove, > .driver = { > .name = "broadwell-audio", > + .pm = &snd_soc_pm_ops > }, > }; > >