On 11/5/20 9:02 AM, Mark Brown wrote:
On Thu, Nov 05, 2020 at 10:20:33AM +0800, Tzung-Bi Shih wrote:
If nau8315 doesn't share I2S with other components for now, it could
be better to not introduce the software mute control.
The mute callback is there because there's some controllers that don't
start up cleanly and end up outputing glitches (for example due to not
being able to flush their FIFOs) - keeping the CODEC muted until after
the I2S is running covers those glitches.
Thanks for explaining those dependencies. The code looks good to me:
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
