Re: [PATCH] ASoC: rt1015: add delay to fix pop noise from speaker

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 02, 2020 at 08:45:33AM -0600, Pierre-Louis Bossart wrote:

> > +static void rt1015_parse_dt(struct rt1015_priv *rt1015, struct device *dev)
> > +{
> > +	device_property_read_u32(dev, "realtek,power-up-delay",
> > +		&rt1015->pdata.power_up_delay);
> > +}

> Don't you need a DT binding description? And use delay-ms maybe?

Yes, any new bindings need to be documented and things should have their
units as a suffix.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux