On Thu, 29 Oct 2020 08:42:37 +0100, Coiby Xu wrote: > > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu <coiby.xu@xxxxxxxxx> It caused compile warnings. Was it already addressed in general? Or we may use __maybe_unused attribute instead, but it's just a matter of taste. thanks, Takashi > --- > sound/core/pcm.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/sound/core/pcm.c b/sound/core/pcm.c > index be5714f1bb58..5a281ac92958 100644 > --- a/sound/core/pcm.c > +++ b/sound/core/pcm.c > @@ -599,7 +599,6 @@ static const struct attribute_group *pcm_dev_attr_groups[]; > * PM callbacks: we need to deal only with suspend here, as the resume is > * triggered either from user-space or the driver's resume callback > */ > -#ifdef CONFIG_PM_SLEEP > static int do_pcm_suspend(struct device *dev) > { > struct snd_pcm_str *pstr = container_of(dev, struct snd_pcm_str, dev); > @@ -608,7 +607,6 @@ static int do_pcm_suspend(struct device *dev) > snd_pcm_suspend_all(pstr->pcm); > return 0; > } > -#endif > > static const struct dev_pm_ops pcm_dev_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(do_pcm_suspend, NULL) > -- > 2.28.0 >