Thanks Pierre for review on all the patches. On 26/10/2020 19:58, Pierre-Louis Bossart wrote:
Run cppcheck on this sort of code: cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive --enable=all --suppress=variableScope sound/soc/codecs/lpass-wsa-macro.c
I normally do sparse checks before sending patches, which did not catch these.
thanks for the suggestion, I will keep add these checks to my future patches.
And w.r.t comments, I agree with all the changes and will send v2 with those fixed!
thanks, srini
