On Wed, 21 Oct 2020 17:03:11 +0200, Hui Wang wrote: > > Looks like this will not bring problem on patch_sigmatel.c, NULL and > valid kernel pointer are same for IS_ERR(), they will not make > IS_ERR() come true. Right, and it's called only once, so the bug doesn't hit. But we should address the potential bug nevertheless, of course :) thanks, Takashi