On Mon, Oct 19, 2020 at 08:31:29PM +0800, Defang Bo wrote: > Just as the commit <4cb79ef9c6c4>("ASoC: amd: Fix potential NULL pointer dereference"),it makes no sense to allocate any resources if res = platform_get_resource(pdev, IORESOURCE_MEM, 0); fails,so move the call to devm_kzalloc() below the mentioned code. Please keep your commit message wrapped at below 80 columns. > - if (!adata) > - return -ENOMEM; > - > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) { > dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n"); > return -ENOMEM; > } > + adata = devm_kzalloc(&pdev->dev, sizeof(struct i2s_dev_data), GFP_KERNEL); This is missing a blank line between the two code blocks.
Attachment:
signature.asc
Description: PGP signature