On 10/12/20 6:55 PM, Randy Dunlap wrote: > On 10/12/20 6:31 PM, Pierre-Louis Bossart wrote: >> >>>> +config SND_SOC_SOF_CLIENT >>>> + tristate >>>> + select ANCILLARY_BUS >>>> + help >>>> + This option is not user-selectable but automagically handled by >>>> + 'select' statements at a higher level >>>> + >>>> +config SND_SOC_SOF_CLIENT_SUPPORT >>>> + bool "SOF enable clients" >>> >>> Tell users what "SOF" means. >> >> This option can only be reached if the user already selected the topic-level option. From there on the SOF acronym is used. Is this not enough? > > Yes, that's enough. I didn't see it. Sorry about that. Huh. I still don't see that Kconfig option. Which patch is it in? I only saw patches 1,2,3 on LKML. >> config SND_SOC_SOF_TOPLEVEL >> bool "Sound Open Firmware Support" >> help >> This adds support for Sound Open Firmware (SOF). SOF is a free and >> generic open source audio DSP firmware for multiple devices. >> Say Y if you have such a device that is supported by SOF. >> >>> >>>> + depends on SND_SOC_SOF >>>> + help >>>> + This adds support for ancillary client devices to separate out the debug >>>> + functionality for IPC tests, probes etc. into separate devices. This >>>> + option would also allow adding client devices based on DSP FW >>> >>> spell out firmware >> >> agree on this one. >> >>> >>>> + capabilities and ACPI/OF device information. >>>> + Say Y if you want to enable clients with SOF. >>>> + If unsure select "N". >>>> + >>> >>> > > thanks. > -- ~Randy