On Tue, 2020-10-06 at 15:43 -0500, Rob Herring wrote: > On Fri, Oct 02, 2020 at 03:35:42PM +0800, Jiaxin Yu wrote: > > This patch adds document for the machine board with mt6358, rt1015 and rt5682. > > > > Signed-off-by: Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> > > --- > > .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 44 +++++++++++++++++++ > > 1 file changed, 44 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > new file mode 100644 > > index 0000000000000..dff5004cd0368 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/mt8192-mt6359-rt1015-rt5682.yaml > > @@ -0,0 +1,44 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license new bindings: > > (GPL-2.0-only OR BSD-2-Clause) > Ok, got it. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/mt8192-mt6359-rt1015-rt5682.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Mediatek MT8192 with MT6359, RT1015 and RT5682 ASoC sound card driver > > + > > +maintainers: > > + - Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> > > + - Shane Chien <shane.chien@xxxxxxxxxxxx> > > + > > +description: > > + This binding describes the MT8192 sound card. > > + > > +properties: > > + compatible: > > + contains: > > Drop this. Other strings shouldn't be allowed. > Should I need to remove "contains"? > > + const: mediatek,mt8192_mt6359_rt1015_rt5682 > > Just a list of part numbers? A different codec would be a different > compatible and driver? You should have a link to the codec and you can > read it's compatible to get what codec you have. > THis bindings is dedicated to the mt8192 with mt6359, rt1015 and rt5682. We are not ready to configure dai-link in DTS. Is this mandatory now? > > + > > + mediatek,platform: > > + $ref: "/schemas/types.yaml#/definitions/phandle" > > + description: | > > + The DT/OF node which is used to specify the link's platform driver. > > What's "link's platform driver"? A DT doesn't have drivers. > There's something wrong with my description. "mediatek,platform" is the phandle of MT8192 ASoC platform. > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - mediatek,platform > > + > > +examples: > > + - | > > + > > + sound: mt8192-sound { > > + compatible = "mediatek,mt8192-mt6359-rt1015-rt5682"; > > + mediatek,platform = <&afe>; > > + pinctrl-names = "aud_clk_mosi_off", > > + "aud_clk_mosi_on"; > > + pinctrl-0 = <&aud_clk_mosi_off>; > > + pinctrl-1 = <&aud_clk_mosi_on>; > > + }; > > + > > +... > > -- > > 2.18.0
