> -----Original Message----- > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Sent: Thursday, October 1, 2020 4:02 AM > To: Ertman, David M <david.m.ertman@xxxxxxxxx> > Cc: alsa-devel@xxxxxxxxxxxxxxxx; tiwai@xxxxxxx; broonie@xxxxxxxxxx; pierre- > louis.bossart@xxxxxxxxxxxxxxx; Sridharan, Ranjani > <ranjani.sridharan@xxxxxxxxx>; jgg@xxxxxxxxxx; parav@xxxxxxxxxx; Patil, > Kiran <kiran.patil@xxxxxxxxx>; Ranjani Sridharan > <ranjani.sridharan@xxxxxxxxxxxxxxx>; Fred Oh <fred.oh@xxxxxxxxxxxxxxx>; > Saleem, Shiraz <shiraz.saleem@xxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx>; Williams, Dan J <dan.j.williams@xxxxxxxxx> > Subject: Re: [PATCH 1/6] Add ancillary bus support > > On Wed, Sep 30, 2020 at 03:50:46PM -0700, Dave Ertman wrote: > > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > > index 397e35392bff..1fd238094543 100644 > > --- a/drivers/bus/Makefile > > +++ b/drivers/bus/Makefile > > @@ -3,6 +3,9 @@ > > # Makefile for the bus drivers. > > # > > > > +#Ancillary bus driver > > Nit, you need a space :) Fixed for next version 😊 > > > +obj-$(CONFIG_ANCILLARY_BUS) += ancillary.o > > And why not put this in drivers/base/? Why way over here in > drivers/bus? My only reason was that this is a bus, and I wagered that buses should go into the bus subdirectory. 😊 > > thanks, > > greg k-h -DaveE