On Thu, Oct 01, 2020 at 08:58:47AM -0300, Jason Gunthorpe wrote: > On Thu, Oct 01, 2020 at 01:05:51PM +0200, Greg KH wrote: > > > You have to be _VERY_ careful after calling > > ancillary_device_initialize(), as now you can not just free up the > > memory if something goes wrong before ancillary_device_add() is called, > > right? > > I've looked at way too many versions of this patch and related. This > is the only one so far that I didn't find various bugs on the error > cases. But you haven't seen the callers of this function. Without this documented, you will have problems. Why is this two-step process even needed here? thanks, greg k-h
