On Wed, Sep 30, 2020 at 01:08:49PM +0100, Mark Brown wrote: > On Wed, Sep 30, 2020 at 01:59:15PM +0200, Greg KH wrote: > > On Fri, Sep 25, 2020 at 05:48:55PM +0100, Srinivas Kandagatla wrote: > > > > +int devm_regmap_field_bulk_alloc(struct device *dev, struct regmap *regmap, > > > + struct regmap_field **field, > > > + struct reg_field *reg_field, int num_fields); > > > +void devm_regmap_field_bulk_free(struct device *dev, > > > + struct regmap_field *field); > > > + > > > > You only have a patch that uses these last two functions, so why add all > > 4? We don't add infrastructure to the kernel without users. > > We have managed versions of the other regmap allocation functions, it > makes sense for consistency to have managed versions of these too. I > think there's a meaningful difference between a simple and expected > wrapper like these and infrastructure which hasn't been proved out by > users. Ok, do you think these are really needed? A review would be nice :) thanks, greg k-h
